Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete messages API #194

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Add delete messages API #194

merged 2 commits into from
Aug 9, 2024

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Aug 8, 2024

feat(history): add delete messages API

Add delete message API support to the advanced history module.

Add `delete message` API support to advanced history module.
@parfeon parfeon added status: done This issue is considered resolved. priority: high This PR should be reviewed ASAP. type: feature This PR contains new feature. labels Aug 8, 2024
@parfeon parfeon self-assigned this Aug 8, 2024
@parfeon parfeon changed the title Add delete message pubnub_api_types Add delete messages API Aug 8, 2024
Copy link
Contributor

@Xavrax Xavrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be valid
great job!

Comment on lines +87 to +88
int pubnub_get_chan_msg_counts(pubnub_t* pb,
size_t* io_count,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange formatter ;o

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xavrax It aligns argument names, and the next line has a pretty long type, so it added that much to the other lines.
This is the default CLion formatter behavior.

@Xavrax
Copy link
Contributor

Xavrax commented Aug 9, 2024

@pubnub-release-bot release

@Xavrax Xavrax merged commit 82fdbea into master Aug 9, 2024
6 checks passed
@Xavrax Xavrax deleted the CLEN-2197 branch August 9, 2024 03:12
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high This PR should be reviewed ASAP. status: done This issue is considered resolved. type: feature This PR contains new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants