Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix custom bool type for CMake builds #193

Merged
merged 4 commits into from
Aug 5, 2024
Merged

fix custom bool type for CMake builds #193

merged 4 commits into from
Aug 5, 2024

Conversation

Xavrax
Copy link
Contributor

@Xavrax Xavrax commented Aug 5, 2024 •
edited
Loading

fix: fix custom bool type for CMake builds

fixed custom bool type for CMake builds

@Xavrax Xavrax marked this pull request as ready for review August 5, 2024 12:32
@Xavrax Xavrax changed the title fix bool type for CMake builds fix custom bool type for CMake builds Aug 5, 2024
seba-aln
seba-aln reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@seba-aln seba-aln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Xavrax Xavrax added priority: high This PR should be reviewed ASAP. type: fix This PR contains fixes to existing features. labels Aug 5, 2024
@seba-aln seba-aln self-requested a review August 5, 2024 13:00
@Xavrax
Copy link
Contributor Author

Xavrax commented Aug 5, 2024

@pubnub-release-bot release

@Xavrax Xavrax merged commit 966e078 into master Aug 5, 2024
6 checks passed
@Xavrax Xavrax deleted the feat/fix-bool-type branch August 5, 2024 13:18
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seba-aln seba-aln seba-aln approved these changes

@parfeon parfeon Awaiting requested review from parfeon parfeon is a code owner

Assignees
No one assigned
Labels
priority: high This PR should be reviewed ASAP. type: fix This PR contains fixes to existing features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xavrax @pubnub-release-bot @seba-aln