Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #8542 Add followers/following count in followers/followin… #9301

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

17sushmita
Copy link
Member

@17sushmita 17sushmita commented Mar 14, 2021

Fixes #9319

Added followers/following count with respective tab name without counting banned users

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

**test_user_2 is banned
**merging PR #9300 will remove banned users from list

Before
image

After
image

@17sushmita 17sushmita requested a review from a team as a code owner March 14, 2021 16:13
@gitpod-io
Copy link

gitpod-io bot commented Mar 14, 2021

@codeclimate
Copy link

codeclimate bot commented Mar 14, 2021

Code Climate has analyzed commit 301ab29 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@56139e9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9301   +/-   ##
=======================================
  Coverage        ?   50.14%           
=======================================
  Files           ?       98           
  Lines           ?     6033           
  Branches        ?        0           
=======================================
  Hits            ?     3025           
  Misses          ?     3008           
  Partials        ?        0           

@cesswairimu
Copy link
Collaborator

Hi @17sushmita I have created an issue for the two issues you fixed on this PR #9319 and linked it here so that we can keep the parent PR open until all the enhancements are done...please do the same for the other subtasks you will be working on..thanks for working on this

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good...thanks

@cesswairimu cesswairimu merged commit 1a8c52c into publiclab:main Mar 16, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Following/followers page: remove bannned users and show count
2 participants