Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followers/Following page enhancements #8542

Open
cesswairimu opened this issue Oct 12, 2020 · 16 comments · May be fixed by #11736
Open

Followers/Following page enhancements #8542

cesswairimu opened this issue Oct 12, 2020 · 16 comments · May be fixed by #11736
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) discussion enhancement explains that the issue is to improve upon one of our existing features

Comments

@cesswairimu
Copy link
Collaborator

cesswairimu commented Oct 12, 2020

The following/followers page is coming together https://publiclab.org/people/liz/followers . Lets brainstorm on ideas to improve it

Screenshot from 2020-10-12 17-26-40

maybe order the list in asc ? load 15 or 20 per page? show user avatar? Any other ideas are welcome

cc: @renugasaraswathy @Tlazypanda @ebarry @jywarren @sagarpreet-chadha

@cesswairimu cesswairimu added discussion enhancement explains that the issue is to improve upon one of our existing features design issue requires more design work and discussion (i.e. mockups and sketches) labels Oct 12, 2020
@cesswairimu cesswairimu changed the title Maybe we can discuss on ways to improve this further maybe order the page, maybe order the list in asc or maybe load 15 or 20 per page in a new issue? Followers/Following page enhancements Oct 12, 2020
@RuthNjeri
Copy link
Contributor

Yes, ordering the page in asc order is a good idea, also, I noticed that when I click the last page for Liz's followers, a notification pops up that a user has been banned, however, I didn't click on any user, just the page number(12)..this could be another issue?

Screenshot 2020-10-12 at 17 29 06

@cesswairimu
Copy link
Collaborator Author

I can't see that error on my end. I tried even when logged out would you mind refreshing and see if you will still get the error?

@RuthNjeri
Copy link
Contributor

@cesswairimu I'm not seeing the error now, I think refreshing the page made it clear.

I think adding an avatar for the followers and following list is good too, also, we can add their bio if present, beneath the names..

I am curious, if a user has been banned, should they still show up as following a user or being followed?

@cesswairimu
Copy link
Collaborator Author

I agree removing banned users from the list would be ideal
I am thinking adding bio below might make the list a bit longer... maybe we could display the bio on hover?

@dldisha
Copy link
Contributor

dldisha commented Oct 12, 2020

@cesswairimu I think we should add a count of the number of followers and following too in the respective tabs itself.

One more suggestion, can we add the remove follower button beside each user?

@dldisha
Copy link
Contributor

dldisha commented Oct 12, 2020

One more update/suggestion that I would like to add is that instead of showing bio on hover can we show each follower/following name under their username in an italic grey text format?

@RuthNjeri
Copy link
Contributor

@dldisha adding a count for followers/following is a great idea, since it is not displayed on a user's profile, unless it is shown, @cesswairimu is the followers/following link on a page somewhere or is it typed on the URL bar? I haven't seen it on this user's profile
Screenshot 2020-10-12 at 17 54 52

About removing a follower beside each user @dldisha, I think that button would only appear to the owner of the account.. like Liz in this case? Also, why would one want to remove a follower or is that similar to blocking a user?

@cesswairimu
Copy link
Collaborator Author

Just noting after #8462 the links are added on the profile page

@RuthNjeri
Copy link
Contributor

Just noting after #8462 the links are added on the profile page

I see, so the suggestion @dldisha shared on adding the count on the followers/following page is valid since it hasn't been implemented on that PR...

@stacytonui
Copy link
Contributor

Suggestion: maybe reduce the column size a bit(col-6) still in the centre..so that you could add other links/activity on each side.
Yes the user avatar would be a good idea

@ghost
Copy link

ghost commented Oct 14, 2020

Suggestions :

  1. It might be great to allow for some padding between the user icon and the users' name. Looks a little bit too muddled up. It might benefit from some breathing space.
  2. It would be great if there could be a small span that shows the count of followers and following. Maybe just beside the following and follower text with a little left padding separating them
  3. I think there should be a limit of 10users on each page to avoid top bottom scrolling. With the current implementation, it looks just perfect, all the names are showing without scrolling, but the pagination isn't. I think that should be fixed.
  4. The columns look a little bit underused. Like @stacytonui mentioned, maybe the widths could be reduced and the remaining space can be used for something else.
  5. On clicking the individual users' name or clicking the next page in the pagination component below, I get the message that the user is banned. I have refreshed severally but there is no change

@StlMaris123
Copy link
Collaborator

How about using a grid?

@17sushmita
Copy link
Member

17sushmita commented Mar 3, 2021

These sub-tasks can be performed to enhance the Followers/Following page-

What do you say @cesswairimu @jywarren?

I would like to try these in incremental order one by one at a time. At present, I would like to try the first one although it might take a little longer to understand the database structure how to identify if the user is banned. Any help would be appreciated.

@17sushmita
Copy link
Member

pinging @cesswairimu @jywarren to review the above comment. Thanks

@cesswairimu
Copy link
Collaborator Author

HI @17sushmita so sorry I missed the first ping, I love the sub tasks..you can go ahead...
a banned user has a status: 0 ...feel free to reach out if you need more clarifications on this. Thanks

@17sushmita
Copy link
Member

HI @17sushmita so sorry I missed the first ping, I love the sub tasks..you can go ahead...
a banned user has a status: 0 ...feel free to reach out if you need more clarifications on this. Thanks

Thank You!! will start working on it today.

17sushmita added a commit to 17sushmita/plots2 that referenced this issue Mar 14, 2021
17sushmita added a commit to 17sushmita/plots2 that referenced this issue Mar 14, 2021
17sushmita added a commit to 17sushmita/plots2 that referenced this issue Mar 15, 2021
cesswairimu pushed a commit that referenced this issue Mar 16, 2021
…9300)

* Fix part of #8542 Removed banned users from followers/following list

* fixed codeclimate issue on the previous commit
jywarren pushed a commit that referenced this issue Mar 16, 2021
* Fix part of #8542 Enhance Followers/Following Page

* Refactured previous commit changes
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
…ing list (publiclab#9300)

* Fix part of publiclab#8542 Removed banned users from followers/following list

* fixed codeclimate issue on the previous commit
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
* Fix part of publiclab#8542 Enhance Followers/Following Page

* Refactured previous commit changes
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
…ing list (publiclab#9300)

* Fix part of publiclab#8542 Removed banned users from followers/following list

* fixed codeclimate issue on the previous commit
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
* Fix part of publiclab#8542 Enhance Followers/Following Page

* Refactured previous commit changes
@sanjanaimandi sanjanaimandi linked a pull request Sep 28, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) discussion enhancement explains that the issue is to improve upon one of our existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants