-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followers/Following page enhancements #8542
Comments
I can't see that error on my end. I tried even when logged out would you mind refreshing and see if you will still get the error? |
@cesswairimu I'm not seeing the error now, I think refreshing the page made it clear. I think adding an avatar for the followers and following list is good too, also, we can add their bio if present, beneath the names.. I am curious, if a user has been banned, should they still show up as following a user or being followed? |
I agree removing banned users from the list would be ideal |
@cesswairimu I think we should add a count of the number of followers and following too in the respective tabs itself. One more suggestion, can we add the remove follower button beside each user? |
One more update/suggestion that I would like to add is that instead of showing bio on hover can we show each follower/following name under their username in an italic grey text format? |
@dldisha adding a count for followers/following is a great idea, since it is not displayed on a user's profile, unless it is shown, @cesswairimu is the followers/following link on a page somewhere or is it typed on the URL bar? I haven't seen it on this user's profile About removing a follower beside each user @dldisha, I think that button would only appear to the owner of the account.. like Liz in this case? Also, why would one want to remove a follower or is that similar to blocking a user? |
Just noting after #8462 the links are added on the profile page |
Suggestion: maybe reduce the column size a bit(col-6) still in the centre..so that you could add other links/activity on each side. |
Suggestions :
|
How about using a grid? |
These sub-tasks can be performed to enhance the Followers/Following page-
What do you say @cesswairimu @jywarren? I would like to try these in incremental order one by one at a time. At present, I would like to try the first one although it might take a little longer to understand the database structure how to identify if the user is banned. Any help would be appreciated. |
pinging @cesswairimu @jywarren to review the above comment. Thanks |
HI @17sushmita so sorry I missed the first ping, I love the sub tasks..you can go ahead... |
Thank You!! will start working on it today. |
…/following page
* Fix part of #8542 Enhance Followers/Following Page * Refactured previous commit changes
…ing list (publiclab#9300) * Fix part of publiclab#8542 Removed banned users from followers/following list * fixed codeclimate issue on the previous commit
…/following page (publiclab#9301)
* Fix part of publiclab#8542 Enhance Followers/Following Page * Refactured previous commit changes
…ing list (publiclab#9300) * Fix part of publiclab#8542 Removed banned users from followers/following list * fixed codeclimate issue on the previous commit
…/following page (publiclab#9301)
* Fix part of publiclab#8542 Enhance Followers/Following Page * Refactured previous commit changes
The following/followers page is coming together https://publiclab.org/people/liz/followers . Lets brainstorm on ideas to improve it
maybe order the list in asc ? load 15 or 20 per page? show user avatar? Any other ideas are welcome
cc: @renugasaraswathy @Tlazypanda @ebarry @jywarren @sagarpreet-chadha
The text was updated successfully, but these errors were encountered: