Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 1.16 HAFAS protocol #23

Merged
merged 13 commits into from
Mar 6, 2018
Merged

use 1.16 HAFAS protocol #23

merged 13 commits into from
Mar 6, 2018

Conversation

derhuerst
Copy link
Member

PR for #3

@derhuerst
Copy link
Member Author

derhuerst commented Mar 4, 2018

The VBB endpoint does not support the numF parameter in combination with the new 1.16 protocol, it just fails with CGI_READ_FAILED. The numF parameter determines the number of journeys in the journeys() method.

There is a mechanism to get subsequent journeys by providing a certain key, but I haven't figured out how to use it yet. This means that, currently, we have no proper way to ensure a certain number of journeys. Technically, it would be a breaking change to remove the results option and just return the number of journeys that they provide, because people might expect hafas-client to return a certain number of journeys.

@deg0nz @jfilter @juliuste @blydro What do you think should be done? Release the (technically breaking change as 3.0.0, or just as 2.3.4?

@derhuerst
Copy link
Member Author

derhuerst commented Mar 4, 2018

I have figured it out. In the VBB case, I will let hafas-client send more requests to collect the number of results. Although this may lead to e.g. 10 requests to fulfill a single journeys() call, I can circumvent a breaking change.

Sorry for pinging you all.

@derhuerst derhuerst merged commit 084fed7 into master Mar 6, 2018
derhuerst added a commit that referenced this pull request Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant