-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cw1155 and cw1155-metatdat-onchain #78
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense for cw1155 to live in this repo. Happy to take another look after it has been updated to the latest versions and modernized (i.e: uses query response types, cw_serde
macro, etc.).
Hi! I was rapidly looking at this contract to provide some support. Here, the token increment happens only if the token does not already exist. What do you think? |
@@ -0,0 +1,41 @@ | |||
use cosmwasm_std::{attr, Response, Uint128}; | |||
use cw_utils::Event; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try removing the dependency on this Event trait? I think we should remove it from cw_utils (CosmWasm/cw-minus#17).
You probably can design this simpler without a trait but if you really need/want it, it's better to have it in here.
Thanks!
development of cw1155 is being continued here: #162 |
Cw1155 PR seems stop update. So I made new PR for adding cw1155
Most of the codes are based on cw-plus repository
What is Added?
token_uri
andextension
(metadata) when the first mint.all_balances
) bytoken_id
NumTokens
queryMinter
queryWhat is Removed?
batch_mint