Update the docs for prioritize #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've written the docs with focus on a new user that implements a dependency provider for the first time rather than with a focus on exact definitions.
Eh2406
reviewed
Jan 24, 2025
src/solver.rs
Outdated
| /// Decisions are always made for the highest priority package first. The order of decisions | ||
| /// determines which solution is chosen and can drastically change the performances of the | ||
| /// solver. If there is a conflict between two package versions, the package with the higher | ||
| /// priority is preserved and the lower priority gets discarded. Usually, you want to decide |
There was a problem hiding this comment.
If there is a conflict between two package versions, the priority is preserved and the lower priority gets discarded.
I'm not following. What scenario are you trying to describe?
There was a problem hiding this comment.
Added the word "decision".
Say:
choose A
decide A 2
choose B
decide B 2
and then we discover A 2 -> C 1, B 2 -> C 2.
In this case, we will next try B 1, not A 1: The version of A 2 gets preserved, while B 2 gets discarded.
There was a problem hiding this comment.
Perhaps: "If there is a conflict between two package versions, decisions will be backtracked until the lower priority package version is discarded preserving the higher priority package." or something.
Eh2406
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written the docs with focus on a new user that implements a dependency provider for the first time rather than with a focus on exact definitions.