fix: required condition

pubg · Sep 18, 2023 · 6b058ee · 6b058ee
1 parent 1695fd3
commit 6b058ee
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/pkg/modules/1_middleend_generator.go b/pkg/modules/1_middleend_generator.go
@@ -34,7 +34,7 @@ func buildFromMessage(pluginOptions *proto.PluginOptions, message pgs.Message, m
 			}}
 		}
 
-		if !field.InRealOneOf() && !field.HasOptionalKeyword() && !field.Type().IsRepeated() {
+		if !field.InRealOneOf() && !field.HasOptionalKeyword() && !field.Type().IsRepeated() && !field.Type().IsMap() {
 			// If field is not a member of oneOf
 			schema.Required = append(schema.Required, propName)
 		}

diff --git a/testdata/cases/plugin-entrypoint/test.schema.json b/testdata/cases/plugin-entrypoint/test.schema.json
@@ -21,8 +21,7 @@
       "required": [
         "int32",
         "int32_2",
-        "string",
-        "map"
+        "string"
       ],
       "description": "This is values2 message"
     },

diff --git a/testdata/cases/proto-map/test.schema.json b/testdata/cases/proto-map/test.schema.json
@@ -35,16 +35,7 @@
           "$ref": "#/$defs/.tests.Values.enum_map"
         }
       },
-      "type": "object",
-      "required": [
-        "basic_map",
-        "int_map",
-        "float_map",
-        "bool_map",
-        "string_map",
-        "nested_map",
-        "enum_map"
-      ]
+      "type": "object"
     },
     ".tests.Values.basic_map": {
       "additionalProperties": {