-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Dockerfile to prepare for production #66
Conversation
…dding environment var file
I didnt have access to the circle ci, pipeline before so I have to make sure that it passes before moving forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Once these changes are addressed, I'll be able to test locally and provide final feedback. Some of these suggestions are to be more in line with our other apps, others are best practices to reduce layers/size in the resulting image.
Please ask any questions you might have
@whereismyjetpack should we re-review this and merge? It fell through the cracks on my to-do items. I can't remember if we are good to merge or what the next steps will be |
we'll need @ajkiessl to test locally to make sure it works for him |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this looks good. I just added one change request for the db seeding. Everything seems to be working when I run this locally.
The QA deployment has some issues, though. First, the db seed wasn't there so I manually ran that to get the integrations page working. Second, there are some configurations that aren't being loaded. We'll have to come up with a strategy for these. The two configs needed are activity_insight.yml
and the integration_passcode.yml
. The .circleci
versions of these in source control map out what values we need. I'm assuming we'll want to use the same strategy the database.yml is using (loading ENV variables). I can meet to go over these if you want. Finally, there's a directory that needs added to store the post print files. I'm getting this error when I go to that page: Errno::ENOENT (No such file or directory @ dir_initialize - /app/public/post_prints)
. So, I think that directory just needs added.
I'm assuming the files and database data will be migrated from the old setup to the new setup when we push this to production?
Add hostname so script can run in multiple environments
Variable Name fixup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say this is good to go
Cleaning up Dockerfile, setting up local_setup script (for local development), modifying docker-compose to include environment variables (these environment variables will need to be configured in the build environment as well in circle ci)