Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip null byte from baseagreement #51

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Strip null byte from baseagreement #51

merged 1 commit into from
Sep 12, 2023

Conversation

ajkiessl
Copy link
Contributor

@ajkiessl ajkiessl commented Sep 12, 2023 •
edited
Loading

closes #50

@ajkiessl
Copy link
Contributor Author

I ran the integration with beta locally and this seems to fix the issue.

@ajkiessl ajkiessl marked this pull request as ready for review September 12, 2023 19:13
@ajkiessl
Copy link
Contributor Author

I was going to hold off on fixing this but the FAMS team was receiving complaints about contracts not importing. Turns out it was an easy fix.

Smullz622
Smullz622 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Smullz622 Smullz622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@ajkiessl ajkiessl merged commit c8d81bd into main Sep 12, 2023
4 checks passed
@ajkiessl ajkiessl deleted the 50-osp-import branch September 12, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smullz622 Smullz622 Smullz622 approved these changes

@ddecollo ddecollo Awaiting requested review from ddecollo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSP (Contracts/Grants) Import Failing
2 participants
@ajkiessl @Smullz622