-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Support partial rendering #9
Open
alexander-nitsche
wants to merge
6
commits into
psmb:master
Choose a base branch
from
alexander-nitsche:task-support-partial-rendering
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: Support partial rendering #9
alexander-nitsche
wants to merge
6
commits into
psmb:master
from
alexander-nitsche:task-support-partial-rendering
Commits on Mar 6, 2023
-
FEATURE: Support partial rendering
With this patch, in addition to document nodes, you can also have content nodes (partials) re-rendered via AJAX requests. The identifier of the node is now stored in the cache entry along with the Fusion path and is thus available on request to render the partial.
Configuration menu - View commit details
-
Copy full SHA for 5e0b997 - Browse repository at this point
Copy the full SHA 5e0b997View commit details
Commits on Mar 7, 2023
-
FEATURE: Support nested and standalone Psmb.Ajaxify:RenderPath
A key feature of this package is to associate a partial with a unique partial key for later dedicated rendering in AJAX requests. The implementation strictly relied on a defined position of the responsible Psmb.Ajaxify:RenderPath within the Psmb.Ajaxify:Ajaxify Fusion object. With this patch, that relationship has been relaxed: the Psmb.Ajaxify:RenderPath Fusion object can now be used both standalone and nested within any depth of Psmb.Ajaxify:Ajaxify. However, when used standalone, it must be called at the first level of the partial - in the same way as Psmb.Ajaxify:Ajaxify.
Configuration menu - View commit details
-
Copy full SHA for 49289dc - Browse repository at this point
Copy the full SHA 49289dcView commit details -
FEATURE: Support setting the partial unique key via
pathKey
propertyPsmb.Ajaxify:Ajaxify and Psmb.Ajaxify:RenderPath can be assigned to the same generic property name in all occurrences for better code readability.
Configuration menu - View commit details
-
Copy full SHA for 0aa9a53 - Browse repository at this point
Copy the full SHA 0aa9a53View commit details -
[!!!]FEATURE: Auto-generate unique key of partial
The partial key must be unique per Fusion path and content node. Therefore, the current state of one key per Fusion path is not sufficient. With this patch, the key will be a hash based on both attributes. The hash is generated automatically, thereby removing the requirement for the developer to manually specify a unique key. Because this patch changes the value of the publicly used URL parameter `&ajaxPathKey=<value>` this patch is marked as breaking.
Configuration menu - View commit details
-
Copy full SHA for 03a1ab6 - Browse repository at this point
Copy the full SHA 03a1ab6View commit details -
Previously, partial rendering considered only the Fusion path. With the recent changes, both the Fusion path and the content node, called the partial context, are now considered. Consider this change in the naming conventions. In detail these are: - Public: Rename URL parameter "ajaxPathKey" to "ajaxPartialKey". - Public: Rename `Psmb.Ajaxify:RenderPath` to `Psmb.Ajaxify:PartialSerializer`. - Public: Rename `Psmb.Ajaxify:RenderPathResolver` to `Psmb.Ajaxify:PartialResolver`. - Public: Rename "[P]athsCache" to "[Pp]artialCache" cache identifier. - Private: Use FQDN for \Exception to satisfy the editor :). - Private: Use verbose common "fusionPath" over "path" and "renderPath". - Private: Rename "pathKey" to "partialKey". - Private: Even smaller adjustments .. Since this patch changes the naming of some public elements, it is marked as breaking. And breaking changes are included because there were other breaking changes in this patch already.
Configuration menu - View commit details
-
Copy full SHA for 39b86ba - Browse repository at this point
Copy the full SHA 39b86baView commit details -
Apply PSR-2 and general Neos .editorconfig styles to the codebase to eliminate mixing of styles and facilitate future patching.
Configuration menu - View commit details
-
Copy full SHA for 78a1854 - Browse repository at this point
Copy the full SHA 78a1854View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.