-
Notifications
You must be signed in to change notification settings - Fork 156
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for emojis in hashtags and mentions
- Loading branch information
Showing
3 changed files
with
6 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5332ad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I just tried running this commit, although it still isn't recognizing hashtags with emojis as hashtags. I tested this by adding a breakpoint and when there is an emoji at the end, the hashtag case is never triggered.
I ttried creating a PR with a fix that worked for me but I don't have access to this repository.
If you simply replace
return detect(regex: "[#]\\w\\S*\\b")
withreturn detect(regex: "[#]\\S+")
then you'll find that emojis are detected as part of the tag.