Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing PHP extentions #21

Closed
wants to merge 1 commit into from
Closed

Conversation

melroy89
Copy link
Contributor

@melroy89 melroy89 commented Oct 23, 2023

@orklah Despite PHP version upgrade, I now see other errors during composer install, which are missing PHP extensions. There are required for some composer packages to be present and installed.

@orklah
Copy link
Contributor

orklah commented Oct 24, 2023

That's weird that it wasn't needed before. Nothing changed with your last PR other than the PHP version, I'm really not sure why we would need to include extensions to this after years of working without it

Are you sure it's not something you have to set up differentlly?

@melroy89
Copy link
Contributor Author

melroy89 commented Oct 24, 2023

I'm a new user of your docker / action. Meaning I want to use your project, but it's for the first time!

See my failing job: https://github.com/MbinOrg/mbin/actions/runs/6589081617/job/17962676237?pr=83

Part of pr: MbinOrg/mbin#83

Again, it's nothing that I changed. I'm trying to use this psalm security checker for the first time on my project.

@orklah
Copy link
Contributor

orklah commented Oct 24, 2023

Well, like I said on the issue, I'm really not an expert on Docker so I might be wrong here, however, having to install every extension in the Psalm Dockerfile is not sustainable and will lead to countless PR to add this or that.

My naive vision is that the PHP installation that is needed to install Symfony should probably not be the same as the one that make Psalm run. That way you can have two sets of requirements.

If everything else fails, maybe you could try to install symfony with something like --ignore-platform-reqs so it will install the project even with missing core requirements

@melroy89
Copy link
Contributor Author

Well, like I said on the issue, I'm really not an expert on Docker so I might be wrong here, however, having to install every extension in the Psalm Dockerfile is not sustainable and will lead to countless PR to add this or that.

My naive vision is that the PHP installation that is needed to install Symfony should probably not be the same as the one that make Psalm run. That way you can have two sets of requirements.

If everything else fails, maybe you could try to install symfony with something like --ignore-platform-reqs so it will install the project even with missing core requirements

nevermind.. I will fork this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants