Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone InvokeBuild tasks #35

Merged
merged 3 commits into from
Oct 8, 2019

Conversation

pauby
Copy link
Contributor

@pauby pauby commented Sep 10, 2019

The psake to InvokeBuild conversion is problematic so a standalone InvokeBuild tasks script has been added.

Description

  • Added a standalone IB.tasks.ps1 InvokeBuild tasks script;
  • Disabled the psake -> InvokeBuild tasks conversion in the build;
  • Amended the InvokeBuild Pester test description;

Related Issue

#16

Motivation and Context

The psake conversion is problematic. It was agreed in #16 that the InvokeBuild tasks should be standalone for the time being.

How Has This Been Tested?

The InvokeBuild tasks used are the ones created by the conversion script in the last version - with a couple of fixes to the Assert statement in the Publish task (which did not work in InvokeBuild) and also to fix the Build task to allow it to use $PSBPreference.Build.Dependencies which didn;t work for InvokeBuild.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pauby pauby mentioned this pull request Sep 10, 2019
@devblackops devblackops self-assigned this Sep 23, 2019
@devblackops devblackops self-requested a review September 23, 2019 03:42
@devblackops
Copy link
Member

Thanks @pauby! Sorry I sat on this for so long.

@devblackops devblackops merged commit 8b0bcda into psake:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants