Add PeerDAS reconstruction metrics #14807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatyaRyazantseva
requested review from
kasey,
nalepae and
prestonvanloon
and removed request for
a team
KatyaRyazantseva
changed the title
nalepae
requested changes
Jan 22, 2025
beacon-chain/core/peerdas/helpers.go
Outdated
| @@ -675,3 +675,12 @@ func RecoverCellsAndProofs( | |||
|
|
|||
| return recoveredCellsAndProofs, nil | |||
| } | |||
|
|
|||
| func CellsCount(cellsAndProofs []kzg.CellsAndProofs) int { | |||
There was a problem hiding this comment.
This function is only used in reconstructDataColumns. Could you move it in the corresponding file and make it private?
Also, the range expression you use make a copy of the cells and proofs, which are quite heavy.
https://go.dev/tour/moretypes/16
It would be better to use the i++ version of the loop which does not copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds reconstruction metrics align with the PeerDAS metrics specs:
beacon_data_availability_reconstructed_columns_totalbeacon_data_availability_reconstruction_time_millisecondsWhich issues(s) does this PR fix?
Fixes (partially) #14129
Other notes for review
Acknowledgements