Return an error when attempting to invalidate the finalized checkpoint #14740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
reviewed
Dec 19, 2024
| @@ -23,6 +23,9 @@ func (s *Store) setOptimisticToInvalid(ctx context.Context, root, parentRoot, la | |||
| if node == nil { | |||
| return invalidRoots, errors.Wrap(ErrNilNode, "could not set node to invalid") | |||
| } | |||
| if node.parent == nil { | |||
| return invalidRoots, errors.New("attempting to set the root node to invalid") | |||
There was a problem hiding this comment.
I find this error confusing, makes it sound like there is an ongoing attempt to set the root node to invalid. This follows suit with the phrasing above too
Suggested change
| return invalidRoots, errors.New("attempting to set the root node to invalid") | |
| return invalidRoots, errors.New("could not set the root node to invalid") |
potuz
commented
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return an error instead of panicking if the finalized checkpoint is being marked as invalid.
(h/t @nalepae for finding this)