Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling transparentTarget in Android #49

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enabling transparentTarget in Android #49

wants to merge 4 commits into from

Conversation

witalobenicio
Copy link

No description provided.

@witalobenicio witalobenicio mentioned this pull request Oct 8, 2018
Closed
@prscX
Copy link
Owner

prscX commented Oct 9, 2018

Thanks @witalobenicio for the PR and Effort.

I have tested the same and identified that if target views are within deep hierarchy then the tour is not rendering. However the same works with .forBounds API.

Due to the same problem, I earlier changed it from .forView to .forBounds.

Please suggest. I believe we can't merge the PR since it is not working for few views.

Thanks
</ Pranav >

@witalobenicio
Copy link
Author

witalobenicio commented Oct 9, 2018 •
edited
Loading

@prscX I've tested in my project, and until now, I've got no problems.
For now, I'll be using my fork. If something wrong happen I'll let you know.
But it would be nice if you take a look at the error prevention (when view was added to apptour and then removed from view hierarchy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witalobenicio @prscX