Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubuntu runner image to ubuntu-22.04 #375

Closed
wants to merge 6 commits into from

Conversation

mpwarres
Copy link
Contributor

@mpwarres mpwarres commented Sep 26, 2023

Update ubuntu github runner to the same image used by Envoy:

ubuntu-20.04 -> ubuntu-22.04

Updates to windows and macos runner images will be in separate PRs, since they introduce build failures.

List of available images here.

Partially addresses #372

ubuntu-20.04 -> ubuntu-22.04
windows-2019 -> windows-2022
macos-11 -> macos-12

Signed-off-by: Michael Warres <[email protected]>
@mpwarres
Copy link
Contributor Author

Looks like there's a MacOS build issue and Windows msvc_not_found with the updated runners, working on addressing those.

@PiotrSikora
Copy link
Member

macOS build issue was fixed 8 months ago in v8@de4e49260f908ca31ee64794c89b04cb004554be, so you need to either update V8 first (maybe split this PR into 3 PRs updating each runner separately?) or cherry-pick that fix.

Personally, I'd do the former and update Ubuntu, update V8, update macOS, and then figure out issues with Windows.

@rahulchaphalkar
Copy link

FWIW - While working on windows CI failures for my other PR, I noticed similar issue when I tried with msvc 2022. It seems to be due to msvc 2022 having vcpkg directory inside of VC directory, which throws this check off. More discussion is here bazelbuild/bazel#18592 (comment)
This is resolved in latest bazel as seen here in this patch .
The workaround, if not updating to latest bazel, would be to remove/move vcpkg directory (I needed bazel clean --expunge otherwise it failed). Worked locally for me.

@mpwarres
Copy link
Contributor Author

Great--thanks for the tip @rahulchaphalkar! I've been sidetracked by a few other work items this week but will get back to this this weekend.

Update ubuntu-20.04 -> ubuntu-22.04.

Updates to windows and macos runner images that were originally in this PR will
be performed separately, per @PiotrSikora suggestion in
proxy-wasm#375 (comment).

Signed-off-by: Michael Warres <[email protected]>
@mpwarres mpwarres changed the title Update github runner images Update ubuntu runner image to ubuntu-22.04 Jan 22, 2024
.bazelrc Outdated Show resolved Hide resolved
@martijneken
Copy link
Contributor

The runner image has been updated. Not sure if you still want to send .bazelrc changes.

@mpwarres
Copy link
Contributor Author

Closing this since it is obsoleted by ++@martijneken #408. I don't think the .bazelrc changes here are needed, but if it turns out they are, that would belong in a different PR anyways.

@mpwarres mpwarres closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants