-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions): add stepfunctions service and check stepfunctions_statemachine_logging_enabled
#5466
base: master
Are you sure you want to change the base?
Conversation
You can check the documentation for this PR here -> Prowler Documentation |
fcf088e
to
6636b62
Compare
You can check the documentation for this PR here -> Prowler Documentation |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5466 +/- ##
==========================================
+ Coverage 89.58% 89.69% +0.10%
==========================================
Files 1073 1076 +3
Lines 33237 33385 +148
==========================================
+ Hits 29777 29946 +169
+ Misses 3460 3439 -21 ☔ View full report in Codecov by Sentry. |
…ging_enabled check
6636b62
to
4999bf0
Compare
You can check the documentation for this PR here -> Prowler Documentation |
…hines-Have-Logging-Enabled
You can check the documentation for this PR here -> Prowler Documentation |
"Code": { | ||
"CLI": "aws stepfunctions update-state-machine --state-machine-arn <state-machine-arn> --logging-configuration file://logging-config.json", | ||
"NativeIaC": "", | ||
"Other": "https://docs.aws.amazon.com/step-functions/latest/dg/logging.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Other": "https://docs.aws.amazon.com/step-functions/latest/dg/logging.html", | |
"Other": "https://docs.aws.amazon.com/securityhub/latest/userguide/stepfunctions-controls.html#stepfunctions-1", |
Context
To cover the checks for the Step Functions service, in this PR we have added that service and have also included the logging enabled check: [StepFunctions.1] Step Functions state machines should have logging turned on
Description
This PR adds:
stepfunctions_statemachine_logging_enabled
check.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.