feat(stepfunctions): add stepfunctions service and check stepfunctions_statemachine_logging_enabled
#5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can check the documentation for this PR here -> Prowler Documentation |
AdriiiPRodri
force-pushed
the
PRWLR-4469-Ensure-Step-Functions-State-Machines-Have-Logging-Enabled
branch
from
fcf088e
to
6636b62
Compare
|
You can check the documentation for this PR here -> Prowler Documentation |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5466 +/- ##
==========================================
+ Coverage 89.58% 89.69% +0.10%
==========================================
Files 1073 1076 +3
Lines 33237 33385 +148
==========================================
+ Hits 29777 29946 +169
+ Misses 3460 3439 -21 ☔ View full report in Codecov by Sentry. |
…ging_enabled check
AdriiiPRodri
force-pushed
the
PRWLR-4469-Ensure-Step-Functions-State-Machines-Have-Logging-Enabled
branch
from
6636b62
to
4999bf0
Compare
|
You can check the documentation for this PR here -> Prowler Documentation |
…hines-Have-Logging-Enabled
|
You can check the documentation for this PR here -> Prowler Documentation |
puchy22
reviewed
Oct 23, 2024
| "Code": { | ||
| "CLI": "aws stepfunctions update-state-machine --state-machine-arn <state-machine-arn> --logging-configuration file://logging-config.json", | ||
| "NativeIaC": "", | ||
| "Other": "https://docs.aws.amazon.com/step-functions/latest/dg/logging.html", |
There was a problem hiding this comment.
Suggested change
| "Other": "https://docs.aws.amazon.com/step-functions/latest/dg/logging.html", | |
| "Other": "https://docs.aws.amazon.com/securityhub/latest/userguide/stepfunctions-controls.html#stepfunctions-1", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To cover the checks for the Step Functions service, in this PR we have added that service and have also included the logging enabled check: [StepFunctions.1] Step Functions state machines should have logging turned on
Description
This PR adds:
stepfunctions_statemachine_logging_enabledcheck.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.