feat(elb): add new check elb_is_in_multiple_az
#4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
puchy22
changed the title
elb_is_in_multiple_az
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4829 +/- ##
==========================================
+ Coverage 89.15% 89.18% +0.03%
==========================================
Files 935 936 +1
Lines 28591 28614 +23
==========================================
+ Hits 25489 25520 +31
+ Misses 3102 3094 -8 ☔ View full report in Codecov by Sentry. |
|
You can check the documentation for this PR here -> Prowler Documentation |
…an-multiple-availability-zones
|
You can check the documentation for this PR here -> Prowler Documentation |
…an-multiple-availability-zones
|
You can check the documentation for this PR here -> Prowler Documentation |
sergargar
reviewed
Aug 23, 2024
prowler/providers/aws/services/elb/elb_is_in_multiple_az/elb_is_in_multiple_az.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Aug 23, 2024
prowler/providers/aws/services/elb/elb_is_in_multiple_az/elb_is_in_multiple_az.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Aug 23, 2024
prowler/providers/aws/services/elb/elb_is_in_multiple_az/elb_is_in_multiple_az.py
Outdated
Show resolved
Hide resolved
…vailability-zones' of github.com:prowler-cloud/prowler into PRWLR-4520-classic-load-balancer-should-span-multiple-availability-zones
|
You can check the documentation for this PR here -> Prowler Documentation |
jfagoagas
requested changes
Aug 26, 2024
Co-authored-by: Pepe Fagoaga <[email protected]>
|
You can check the documentation for this PR here -> Prowler Documentation |
jfagoagas
approved these changes
Aug 26, 2024
jfagoagas
deleted the
PRWLR-4520-classic-load-balancer-should-span-multiple-availability-zones
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Checks that Classic Load Balancers are configured with registered instances from at least the specified number of Availability Zones (AZs). The control fails if the load balancer does not span the minimum number of AZs specified.
Description
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.