Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elbv2): add new check elbv2_is_in_multiple_az #4800

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Aug 20, 2024

Context

Checks whether Elastic Load Balancer V2 (Application, Network, or Gateway Load Balancers) is configured with registered instances from at least the specified number of Availability Zones (AZs). The control fails if the load balancer does not span the minimum number of AZs specified.

Description

  • Modify service to add AZs to ELBv2
  • Test service changes
  • Add configurable parameter for the check
  • Add check logic
  • Add unit testing for the check

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners August 20, 2024 10:06
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (dec5fb6) to head (5a83241).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4800      +/-   ##
==========================================
+ Coverage   89.08%   89.14%   +0.05%     
==========================================
  Files         923      931       +8     
  Lines       28274    28504     +230     
==========================================
+ Hits        25189    25409     +220     
- Misses       3085     3095      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puchy22 puchy22 changed the title feat(elbv2): add new check for ensure that ELBv2 is in multiple availability zones feat(elbv2): add new check elbv2_is_in_multiple_az Aug 21, 2024
Comment on lines +319 to +323
# AWS ELBv2 Configuration
# aws.elbv2_is_in_multiple_az
# Minimum number of Availability Zones that an ELBv2 must be in
elbv2_min_azs: 2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add this to the documentation.

Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 👏🏼

@sergargar sergargar merged commit 0b23824 into master Aug 22, 2024
12 checks passed
@sergargar sergargar deleted the PRWLR-4522-application-network-and-gateway-load-balancers-should-span-multiple-availability-zones branch August 22, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants