Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tags): convert tags to a dictionary #4598

Merged
merged 18 commits into from
Aug 5, 2024
Merged

refactor(tags): convert tags to a dictionary #4598

merged 18 commits into from
Aug 5, 2024

Conversation

sergargar
Copy link
Member

@sergargar sergargar commented Jul 31, 2024 •
edited
Loading

Description

Convert all Prowler tags to a dictionary for a better formatting and handling of the attribute across all the providers.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider output/csv Issues/PRs related with the CSV output format output/ocsf Issues/PRs related with the OCSF output format output/asff Issues/PRs related with the ASFF output format output/html Issues/PRs related with the HTML output format integration/security-hub Issues/PRs related with the AWS Security Hub integration integration/s3 Issues/PRs related with the AWS S3 integration mutelist Issues/PRs related with the Mutelist labels Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@sergargar sergargar force-pushed the PRWLR-4383-cannot-mute-failed-checks-based-on-aws-tags-using-4-3-0 branch from 32584a4 to d76693e Compare July 31, 2024 20:06
@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@sergargar sergargar force-pushed the PRWLR-4383-cannot-mute-failed-checks-based-on-aws-tags-using-4-3-0 branch from d76693e to 07bdde2 Compare July 31, 2024 20:06
@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@sergargar sergargar marked this pull request as ready for review July 31, 2024 20:07
@sergargar sergargar requested a review from a team as a code owner July 31, 2024 20:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

You can check the documentation for this PR here -> SaaS Documentation

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (32da86f) to head (029f384).
Report is 3 commits behind head on master.

Files Patch % Lines
prowler/providers/gcp/gcp_provider.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4598      +/-   ##
==========================================
+ Coverage   88.96%   88.99%   +0.02%     
==========================================
  Files         910      910              
  Lines       27694    27696       +2     
==========================================
+ Hits        24638    24648      +10     
+ Misses       3056     3048       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jfagoagas
jfagoagas requested changes Aug 1, 2024
View reviewed changes
tests/lib/outputs/asff/asff_test.py Outdated Show resolved Hide resolved
tests/lib/outputs/asff/asff_test.py Outdated Show resolved Hide resolved
tests/lib/outputs/asff/asff_test.py Outdated Show resolved Hide resolved
tests/lib/outputs/asff/asff_test.py Outdated Show resolved Hide resolved
sergargar and others added 2 commits August 1, 2024 11:05
jfagoagas
jfagoagas requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the finding type to the is_finding_muted method in each provider's Mutelist class?

@jfagoagas jfagoagas self-requested a review August 1, 2024 16:02
jfagoagas
jfagoagas previously approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I can approve it, my 🧠 can rest since the tests covers all the changes in tags and everything works 💯 🚀

@pedrooot
Copy link
Member

pedrooot commented Aug 2, 2024

🔝 @jfagoagas
programming

@jfagoagas jfagoagas self-requested a review August 5, 2024 06:17
@jfagoagas jfagoagas merged commit 95ec3d9 into master Aug 5, 2024
11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-4383-cannot-mute-failed-checks-based-on-aws-tags-using-4-3-0 branch August 5, 2024 06:17
sergargar added a commit that referenced this pull request Aug 5, 2024
@sergargar @jfagoagas
refactor(tags): convert tags to a dictionary (#4598)
c6c06b3 
Co-authored-by: Pepe Fagoaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfagoagas jfagoagas jfagoagas approved these changes

Assignees
No one assigned
Labels
documentation integration/s3 Issues/PRs related with the AWS S3 integration integration/security-hub Issues/PRs related with the AWS Security Hub integration mutelist Issues/PRs related with the Mutelist output/asff Issues/PRs related with the ASFF output format output/csv Issues/PRs related with the CSV output format output/html Issues/PRs related with the HTML output format output/ocsf Issues/PRs related with the OCSF output format provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergargar @pedrooot @jfagoagas