-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tags): convert tags to a dictionary #4598
refactor(tags): convert tags to a dictionary #4598
Conversation
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
1 similar comment
You can check the documentation for this PR here -> SaaS Documentation |
32584a4
to
d76693e
Compare
You can check the documentation for this PR here -> SaaS Documentation |
d76693e
to
07bdde2
Compare
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
You can check the documentation for this PR here -> SaaS Documentation |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4598 +/- ##
==========================================
+ Coverage 88.96% 88.99% +0.02%
==========================================
Files 910 910
Lines 27694 27696 +2
==========================================
+ Hits 24638 24648 +10
+ Misses 3056 3048 -8 ☔ View full report in Codecov by Sentry. |
…-on-aws-tags-using-4-3-0
Co-authored-by: Pepe Fagoaga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the finding type to the is_finding_muted
method in each provider's Mutelist class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I can approve it, my 🧠 can rest since the tests covers all the changes in tags and everything works 💯 🚀
Co-authored-by: Pepe Fagoaga <[email protected]>
Description
Convert all Prowler tags to a dictionary for a better formatting and handling of the attribute across all the providers.
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.