chore: solve comments

prowler-cloud · Jan 10, 2025 · 81eb14c · 81eb14c
1 parent bfc21e3
commit 81eb14c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/prowler/lib/outputs/ocsf/ocsf.py b/prowler/lib/outputs/ocsf/ocsf.py
@@ -127,7 +127,7 @@ def transform(self, findings: List[Finding]) -> None:
                                 type=finding.metadata.ResourceType,
                                 data={
                                     "details": finding.resource_details,
-                                    "metadata": finding.resource_metadata,
+                                    # "metadata": finding.resource_metadata, TODO: add the resource_metadata to the finding
                                 },
                                 namespace=finding.region.replace("namespace: ", ""),
                             )

diff --git a/tests/lib/outputs/ocsf/ocsf_test.py b/tests/lib/outputs/ocsf/ocsf_test.py
@@ -192,7 +192,10 @@ def test_batch_write_data_to_file(self):
                     {
                         "cloud_partition": "aws",
                         "region": "eu-west-1",
-                        "data": {"details": "resource_details", "metadata": {}},
+                        "data": {
+                            "details": "resource_details",
+                            # "metadata": {} TODO: add metadata to the resource details
+                        },
                         "group": {"name": "test-service"},
                         "labels": [],
                         "name": "resource_name",
@@ -318,7 +321,7 @@ def test_finding_output_cloud_pass_low_muted(self):
         assert resource_details[0].region == finding_output.region
         assert resource_details[0].data == {
             "details": finding_output.resource_details,
-            "metadata": {},
+            # "metadata": {}, TODO: add metadata to the resource details
         }
 
         resource_details_group = resource_details[0].group