-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations for Governance Transactions Queries #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a regular view to avoid deadlocks that occur with realtime fetches to the website
…-view' into remove-materialized-view
…emove-materialized-view
…-view' into remove-materialized-view
…t we're ordering outside of the subquery
…-view' into remove-materialized-view
iramiller
previously approved these changes
Jan 9, 2025
ktlint is failing ..but looks good otherwise |
…he 0.47.1 version on version 1.5.0 this needs to be better...
resolved the linting issue. We'll swing back through with a linting update to ktlint 1.5.0 |
arnabmitra
approved these changes
Jan 10, 2025
iramiller
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On 12/24/2024 and issue was found that impacted uptime of the Explorer API. It was determined that a single user was repeatedly querying an endpoint for governance transactions, and that the query was resulting in a long running transaction that after repeatedly being initiated would cause the service to restart. In order to resolve the issues a few performance improvements are in this PR:
Most notable change is in the service/src/main/kotlin/io/provenance/explorer/domain/entities/Transactions.kt file.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes