Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error parsing ibc hooks memo object #503

Merged

Conversation

nullpointer0x00
Copy link
Contributor

Description

Error was caused by trying to convert a json object from a string that contained a string value that was also a json. In this case, the memo field in an ibc packet contained json.

I added tests to confirm that a json that is formatted still passed worked.

closes: #501


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 added the bug Something isn't working label Nov 9, 2023
@nullpointer0x00 nullpointer0x00 self-assigned this Nov 9, 2023
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner November 9, 2023 18:46
@nullpointer0x00 nullpointer0x00 requested a review from a team November 9, 2023 18:46
SpicyLemon
SpicyLemon previously approved these changes Nov 9, 2023
@SpicyLemon
Copy link

ktlint / ktlint (pull_request) is failing. No clue if that's expected or not, though.

Taztingo
Taztingo previously approved these changes Nov 9, 2023
@nullpointer0x00 nullpointer0x00 dismissed stale reviews from Taztingo and SpicyLemon via 2630b02 November 9, 2023 20:41
@nullpointer0x00
Copy link
Contributor Author

@SpicyLemon Thanks! Yeah, I keep forgetting to check that. Need to setup my workspace with intellij better to try to fix that for me. We have it nice with our go project...

@nullpointer0x00 nullpointer0x00 merged commit 196b72e into main Nov 9, 2023
4 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/501-error-parsing-ibc-hooks-memo-object branch November 9, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Error parsing ibc-hooks memo object
4 participants