Added some categorical prior tests that fail #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the `k` argument has been removed from the stat, and it dynamically resizes its counts container, a couple of things will break in ConjugatePrior when the stat is in a degenerate state. It used to be that the stat could not be degenerate, but now the ln_m and ln_pp functions will have be made to work with too-small count vectors and panic with too-large count vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
kargument has been removed from the stat, and it dynamically resizes its counts container, a couple of things will break in ConjugatePrior when the stat is in a degenerate state. It used to be that the stat could not be degenerate, but now the ln_m and ln_pp functions will have be made to work with too-small count vectors and panic with too-large count vectors.