Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to scrape all types of attributes #747

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

umutsahin
Copy link

@umutsahin umutsahin commented Nov 9, 2022

Hi @fstab, @tomwilkie

The reason I have created this PR is while scraping JMX metrics from apache ignite, if I used JMXMetricsSpi, exporter was not able to parse any of the metrics provided by specific SPI. The Attributes are returned as POJOs instead of the expectation Attribute implementation.

I have added an option to scrape everything from JMX, current implementation scrapes Attribute instances only.
Config key: scrapeAllAttributes

Signed-off-by: Umut Sahin [email protected]

@umutsahin umutsahin marked this pull request as ready for review November 9, 2022 14:13
@umutsahin
Copy link
Author

Hi @dhoard, is there anything missing from my side to get this PR merged ?
Thanks!

@dhoard
Copy link
Collaborator

dhoard commented Apr 6, 2023

@umutsahin I don't see any JUnit tests for the changes. (I'm working on a robust integration test suite.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants