Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sorting rules in rule-patching library #1852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid sorting rules in rule-patching library #1852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 24 additions & 29 deletions jsonnet/kube-prometheus/lib/rule-sanitizer.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,41 +74,36 @@ local patchOrExcludeRule(rule, ruleSet, operation) =
else
[] + patchOrExcludeRule(rule, ruleSet[1:], operation);

local findRuleName(rule, ruleSet) =
local _findSameRuleName(rule, ruleSet, index) =
if std.length(ruleSet) == index then
[]
else if (('alert' in rule && 'alert' in ruleSet[index] && rule.alert == ruleSet[index].alert) ||
('record' in rule && 'record' in ruleSet[index] && rule.record == ruleSet[index].record)) then
[index] + _findSameRuleName(rule, ruleSet, index + 1)
else
[] + _findSameRuleName(rule, ruleSet, index + 1);
_findSameRuleName(rule, ruleSet, 0);

local sameRuleName(rule1, rule2) =
if ('alert' in rule1 && 'alert' in rule2) then
rule1.alert == rule2.alert
else if ('record' in rule1 && 'record' in rule2) then
rule1.record == rule2.record
else
false;

local indexRules(lastRule, ruleSet) =
if std.length(ruleSet) == 0 then
[]
else if (lastRule != null) && sameRuleName(lastRule, ruleSet[0]) then
local updatedRule = std.mergePatch(ruleSet[0], { index: lastRule.index + 1 });
[updatedRule] + indexRules(updatedRule, ruleSet[1:])
else
local updatedRule = std.mergePatch(ruleSet[0], { index: 0 });
[updatedRule] + indexRules(updatedRule, ruleSet[1:]);

local ruleName(rule) =
if ('alert' in rule) then
rule.alert
else if ('record' in rule) then
rule.record
else
assert false : 'rule should have either "alert" or "record" field' + std.toString(rule);
'';
local indexRules(ruleSet) =
local _indexRules(ruleSet, index) =
if std.length(ruleSet) == index then
[]
else
// First we find the number of occurences of the rule in the ruleSet and
// get an array containing the indexes of all the occurences.
// Then, based on the current index of the rule in the ruleSet we are able
// to deduce the index of the rule in the list of rules with the same name.
local ruleIndex = std.find(index, findRuleName(ruleSet[index], ruleSet))[0];
local updatedRule = std.mergePatch(ruleSet[index], { index: ruleIndex });
[updatedRule] + _indexRules(ruleSet, index + 1);
_indexRules(ruleSet, 0);

local patchOrExcludeRuleGroup(group, groupSet, operation) =
if std.length(groupSet) == 0 then
[group.rules]
else if (group.name == groupSet[0].name) then
local indexedRules = indexRules(null, std.sort(
group.rules, keyF=ruleName
));
local indexedRules = indexRules(group.rules);
[patchOrExcludeRule(rule, groupSet[0].rules, operation) for rule in indexedRules]
else
[] + patchOrExcludeRuleGroup(group, groupSet[1:], operation);
Expand Down