Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for scraping multiple elasticsearch instance #920

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

support for scraping multiple elasticsearch instance #920

wants to merge 5 commits into from

Conversation

lework
Copy link

@lework lework commented Aug 30, 2024

Pass the es url via the url parameter.

export ES_TEST_USERNAME elastic
export ES_TEST_PASSWORD 123456

http://localhost:9114/probe?target=http://test-elasticsearch-01:9200&auth_module=TEST

@lework lework mentioned this pull request Sep 2, 2024
Open
sysadmind
sysadmind requested changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code, as it is currently, completely removes the metrics collection for the /metrics endpoint. We can't break the single instance functionality when adding the multi target support.

See this PR for a reference where I added multi target support to the postgres_exporter prometheus-community/postgres_exporter#618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysadmind sysadmind sysadmind requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lework @sysadmind