Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability statement #42

Merged
merged 3 commits into from
May 18, 2024
Merged

Capability statement #42

merged 3 commits into from
May 18, 2024

Conversation

elsaperelli
Copy link
Collaborator

@elsaperelli elsaperelli commented May 17, 2024

Summary

Adds a /metdata endpoint to the server to display the capability statement. This is mostly so our server does not show a 404 error in ConMan for the Connectathon!

New behavior

/metadata endpoint returns a 200 code and the capability statement JSON found here. I believe it is reflective of our server's capabilities, but not sure if I need to remove or add anything.

Code changes

  • src/config/capabilityStatementResource.json - capability statement grabbed from the Bulk Data Access IG
  • src/server/app.js - add /metadata endpoint
  • metadata.service.js - service for the capability statement /metadata endpoint

Testing guidance

  • Make sure this makes sense as a capability statement.
  • npm start
  • Send a GET request through Insomnia (or whatever) to http://localhost:3000/metadata and make sure a 200 status code is returned as well as the capability statement.

Copy link

github-actions bot commented May 17, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.36% (-0.23% 🔻)
473/596
🟡 Branches 66.53% 167/251
🟡 Functions
77.08% (-0.81% 🔻)
74/96
🟡 Lines
79.79% (-0.24% 🔻)
466/584
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / metadata.service.js
50% 100% 0% 50%

Test suite run success

76 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 0379016

@hossenlopp hossenlopp merged commit d4868ee into main May 18, 2024
4 checks passed
@hossenlopp hossenlopp deleted the capability-statement branch May 18, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants