Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make port optional #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make port optional #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b843ad7
fix: make port optional
czosel Nov 9, 2023
b93ad24
Set optional settings value to None
fugal-dy Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-compose.override.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ version: '3.4'

services:
proxy:
image: ghcr.io/projectcaluma/s3-hooked:dev
build:
dockerfile: Dockerfile
context: .
Expand Down
3 changes: 1 addition & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ version: '3.4'

services:
proxy:
image: ghcr.io/projectcaluma/s3-hooked:v0.1.0
image: ghcr.io/projectcaluma/s3-hooked:latest
environment:
- PROXY_SECRET
- PROXY_OBJECT_STORE_HOST=${PROXY_OBJECT_STORE_HOST:-minio}
- PROXY_OBJECT_STORE_PORT=${PROXY_OBJECT_STORE_PORT:-9000}
- PROXY_OBJECT_STORE_SSL_ENABLED=${PROXY_OJECT_STORE_SSL_ENABLED:-true}
ports:
- "8080:8000"
Expand Down
4 changes: 2 additions & 2 deletions proxy/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
from typing import List, NamedTuple
from typing import List, NamedTuple, Optional

from pydantic_settings import BaseSettings, SettingsConfigDict


class Settings(BaseSettings):
model_config = SettingsConfigDict(env_prefix="PROXY_")
OBJECT_STORE_HOST: str = "minio"
OBJECT_STORE_PORT: int = 9000
OBJECT_STORE_PORT: Optional[int] = None
OBJECT_STORE_SSL_ENABLED: bool = True
SECRET: str
LOG_LEVEL: str = "info"
Expand Down
Loading