fix(tags): improve tag manager #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
reviewed
Nov 16, 2023
czosel
reviewed
Nov 16, 2023
czosel
reviewed
Nov 16, 2023
addon/services/tags.js
Outdated
| return yield this.store.query("tag", { | ||
| filter: { | ||
| withDocumentsInCategory: this.category, | ||
| search, |
czosel
reviewed
Nov 16, 2023
Yelinz
force-pushed
the
refactor-tag-manager
branch
2 times, most recently
from
5d81b73 to
2af690f
Compare
czosel
previously approved these changes
Nov 16, 2023
improve tag service by moving tag manager parts out
Yelinz
force-pushed
the
refactor-tag-manager
branch
from
2af690f to
c5df998
Compare
|
🎉 This PR is included in version 4.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve tag service by moving tag manager parts out
improved error handling in tag service
requires backend change projectcaluma/alexandria#387