GraphQL 3.0 tracking pull-request

[rhizoome]

Draft PR to track GraphQL 3.0 progress

This:

• 📣 Call for maintainers graphql-python/graphene#1312
• 📣 Call for maintainers graphql-python/graphene-django#1049

means that we finally have to take the GraphQL 3.0 problem seriously. I think we should maintain both projects.

@sbor23 @czosel @winged @open-dynaMIX @kaldras

Status

The tests are green because of pytest-xfaillist. xfail allows to expect tests to fail, but a test that is expected to fail and does not fail is a failure. This allows to track the progress much better.

• Fix snapshot tests
  • Find out what snapshot tests can be updated because of a valid change
  • Fix the rest e.g. the bugs
• ..... ?

[sbor23]

Thanks @ganwell for picking this up!

Just a heads up, I prepared #1140 some time ago but we didn't merge it yet for deprecation reasons. I just rebased it, so there's a slim chance this works out of the box.

You could pick up the small fixes or rebase on top if it helps you in any way. :)

Edit: It's no based on master and should work!

[rhizoome]

You could pick up the small fixes or rebase on top if it helps you in any way. :)

Nice, thanks to xfaillist, I could actually see if rebasing this flips any tests.

[sbor23]

There are some upgrade notes for v3 which could prove handy.

[rhizoome]

@sbor23 #1140 fixed 138 tests.

In [9]: import json

In [10]: with open("xfails.list") as old:
    ...:     old_j = set(json.load(old))
    ...:

In [11]: with open("xfails.list.new") as new:
    ...:     new_j = set(json.load(new))
    ...:

In [12]: len(old_j - new_j)
Out[12]: 138

In [13]: len(new_j - old_j)
Out[13]: 0

[sbor23]

Alright, 57 fewer to go.

From what I've seen, there are 2 main issues:

• Enums: We quite a lot of enum fields for stuff like status, there are some changes, see graphene3: enum doesn't resolve to value graphql-python/graphene#1277 and the upgrade guide.
• Issues around the Mutation base class, we should resolve for this Move closer to upstream ClientIDMutation #1081

[rhizoome]

Superseeded by #1438