[BPF] always use bpf_redir_neigh after FIB lookup #9423
+764
−406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
tomastigera
added
docs-not-required
tomastigera
force-pushed
the
tomas-bpf-redir-neigh
branch
from
6e4a1ad
to
8e4dfd2
Compare
tomastigera
added
release-note-not-required
tomastigera
force-pushed
the
tomas-bpf-redir-neigh
branch
3 times, most recently
from
d285d3d
to
2f15c59
Compare
There is not need to copy and fill in the mac addresses, bpf_redir_neigh will do that for us.
Going forward, we will maintain co-re and will eventually deprecate and remove the legacy one. That will get us back to a single fib.h.
bpf_redir_neigh will do it
bpf_redirect_neigh() will do it.
When redirecting to a workload when NAt is required, usually from HEP because of node port, us the destination IP as the next hop in bpf_redir_neigh() to avoid FIB lookup.
tomastigera
force-pushed
the
tomas-bpf-redir-neigh
branch
from
e71b383
to
6375338
Compare
fasaxc
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Few small nits but great to see the code getting modernised!
There's still quite a lot of shared logic between the two fib impls (I diffed them locally to get a better feel for it) but happy to go with your judgement on the split. Not like we can't roll it back if we find the duplication awkward.
| state->ct_result.ifindex_fwd); | ||
| goto no_fib_redirect; | ||
| } | ||
| CALI_DEBUG("Fall through to redirct without fib lookupi rc %d", rc); |
| case 0: | ||
| case BPF_FIB_LKUP_RET_NO_NEIGH: | ||
| #ifdef IPVER6 | ||
| CALI_DEBUG("FIB lookup succeeded - gw"); |
| @@ -53,6 +53,8 @@ struct calico_ct_leg { | |||
|
|
|||
| __u32 opener:1; | |||
|
|
|||
| __u32 workload:1; | |||
There was a problem hiding this comment.
Can imagine forgetting that this means "the source of this leg is a local workload iface" at some point. Worth a comment just to make ti really clear?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.