Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: Use bootstrap for reveal/collapse contact form #3396

Open
wants to merge 1 commit into
base: release-4.x
Choose a base branch
from
Open

backport: Use bootstrap for reveal/collapse contact form #3396

wants to merge 1 commit into from

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Jan 9, 2025

This provides better accessibility (aria-expanded) than our custom solution

@dnoneill dnoneill changed the title Use bootstrap for reveal/collapse contact form backport: Use bootstrap for reveal/collapse contact form Jan 9, 2025
@dnoneill dnoneill force-pushed the backport-3379 branch 2 times, most recently from f001ca3 to bcaf7cf Compare January 15, 2025 19:37
@jcoyne @dnoneill
Use bootstrap for reveal/collapse contact form
143b08f 
This provides better accessibility (aria-expanded) than our custom solution
@taylor-steve
Copy link
Contributor

This isn't working for me. On the release-4.x branch I see the 'Feedback' link, and it expands on the same page when clicked. On this branch I get directed to the new form when I click the 'Feedback' link. Are you seeing different behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnoneill @taylor-steve @jcoyne