Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple browse windows to be open at the same time #3189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Oct 14, 2024

@dnoneill dnoneill force-pushed the breadcrumbs-multi-page branch 2 times, most recently from 6e1dff6 to b34386e Compare October 15, 2024 17:02
@dnoneill dnoneill marked this pull request as ready for review October 15, 2024 17:02
@jcoyne
Copy link
Member

jcoyne commented Oct 15, 2024

Related to projectblacklight/blacklight#2558

Copy link
Contributor

@corylown corylown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this fixes the issue described in sul-dlss/exhibits#2585

In my testing the app still shows a browse category in the breadcrumb under the conditions described in the issue.

@dnoneill dnoneill force-pushed the breadcrumbs-multi-page branch 3 times, most recently from fca1b65 to b5b97eb Compare October 24, 2024 18:57
@dnoneill
Copy link
Contributor Author

@corylown It was fixing another issue which I have since linked. It should now fix both issues.

Copy link
Contributor

@corylown corylown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing some pretty odd behavior from the breadcrumbs. This does appear to fix the issue with opening two browse categories in different windows. But if I have navigated to an item from a browse category and then go directly to another item in a different window the breadcrumb says "search results" but the link goes to the last browse category I visited.
Screenshot 2024-10-25 at 9 33 16 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants