Don't fail on citations when the 700 only has punctuation and spaces (#…

…117)

* Don't fail on citations when the 700 only has punctuation and spaces

Co-authored-by: Christina Chortaria <[email protected]>
Co-authored-by: Jane Sandberg <[email protected]>

* Incorporate feedback from review

Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Christina Chortaria <[email protected]>

---------

Co-authored-by: Christina Chortaria <[email protected]>
Co-authored-by: Jane Sandberg <[email protected]>

app/models/concerns/blacklight/marc/document_export.rb

@@ -561,6 +561,7 @@ def get_publication_data(record)
 
   def abbreviate_name(name)
     name_parts = name.split(", ")
+    return "" if name_parts.empty?
     first_name_parts = name_parts.last.split(" ")
     temp_name = name_parts.first + ", " + first_name_parts.first[0,1] + "."
     first_name_parts.shift
@@ -570,7 +571,7 @@ def abbreviate_name(name)
 
   def name_reverse(name)
     name = clean_end_punctuation(name)
-    return name unless name =~ /,/
+    return name if name == ", " || !(name =~ /,/)
     temp_name = name.split(", ")
     return temp_name.last + " " + temp_name.first
   end

spec/models/concerns/blacklight/marc/document_export_spec.rb

@@ -26,6 +26,19 @@ def to_marc
   end
 end
 
+class MockClassInvalid700
+  include Blacklight::Marc::DocumentExport
+
+  def to_marc
+    fields = [
+      { "100" => { "subfields" => [{ "a" => "Borja, Ronaldo I." }]}},
+      { "245" => { "ind1" => " ", "ind2" => " ", "subfields" => [{ "a" => "Plasticity : ", "b" => "modeling & computation /", "c" => "Ronaldo I. Borja." }] } },
+      { "700" => { "ind1" => " ", "ind2" => " ", "subfields" => [{ "a" => ", ." }] } }
+    ]
+    MARC::Record.new_from_hash('fields' => fields)
+  end
+end
+
 RSpec.describe Blacklight::Marc::DocumentExport do
   describe 'export citiations from 260 field' do
     it 'exports citations in apa format' do
@@ -60,4 +73,21 @@ def to_marc
       expect(MockClass264.new.export_as_chicago_citation_txt).to include('Berlin: Springer,')
     end
   end
+
+  describe 'when the 700 only has punctuation and spaces' do
+    it 'exports citations in apa format' do
+      expect(MockClassInvalid700.new.export_as_apa_citation_txt).to include('Borja, R. I')
+      expect(MockClassInvalid700.new.export_as_apa_citation_txt).to include('Plasticity')
+    end
+
+    it 'exports citations in mla format' do
+      expect(MockClassInvalid700.new.export_as_mla_citation_txt).to include('Borja, Ronaldo I')
+      expect(MockClassInvalid700.new.export_as_mla_citation_txt).to include('Plasticity')
+    end
+
+    it 'exports citations in Chicago format' do
+      expect(MockClassInvalid700.new.export_as_chicago_citation_txt).to include('Borja, Ronaldo I')
+      expect(MockClassInvalid700.new.export_as_chicago_citation_txt).to include('Plasticity')
+    end
+  end
 end