Ensures this gem works with Rails 7, Ruby 3, and BL 8. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Thanks for your work on this!
It doesn't look like travis CI is still running. I think most blacklight repos use github actions now. It is out of scope of this PR to do that migration but it is hard to have confidence in the changes without CI to prove they're safe. Would you be able to open a PR switching to github actions? If not, you could bring it up on the Samvera tech call and hopefully someone would be able to do that work. At a minimum it could be worked on at the next Samvera developers congress during Connect in October.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.