Enables downloading tracks behind a feature flag #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmskywalker
force-pushed
the
sky/enable_track_downloads
branch
from
e4dd394 to
99f18f6
Compare
newmskywalker
force-pushed
the
sky/enable_track_downloads
branch
from
99f18f6 to
f1a0337
Compare
newmskywalker
temporarily deployed
to
staging
GitHub Actions
Inactive
...d/features/music-player/src/main/java/io/newm/feature/musicplayer/service/DownloadManager.kt
Outdated
Show resolved
Hide resolved
|
Just tested the app, when in airplane mode I am able to listen to music that was previously downloaded, without the visuals. Do we want to include that work as part of this PR or do you prefer to address that on a follow up PR? |
newmskywalker
force-pushed
the
sky/enable_track_downloads
branch
from
f1a0337 to
83f3f3c
Compare
newmskywalker
temporarily deployed
to
staging
GitHub Actions
Inactive
I'll raise a different pr for the progress |
escobarcristhian
approved these changes
Jan 2, 2025
|
@newmskywalker can we merge this PR? |
newmskywalker
force-pushed
the
sky/enable_track_downloads
branch
from
83f3f3c to
95d854a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.