KMP Room DB support #274
Draft
KMP Room DB support #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlara
reviewed
Jun 30, 2024
shared/src/commonMain/kotlin/io.newm.shared/internal/repositories/NewmPolicyIdsRepository.kt
Outdated
Show resolved
Hide resolved
wlara
reviewed
Jun 30, 2024
shared/src/commonMain/kotlin/io.newm.shared/internal/repositories/WalletRepository.kt
Show resolved
Hide resolved
wlara
previously approved these changes
Jun 30, 2024
cristhianescobar
force-pushed
the
cristhian/replace-sqldelight-with-room
branch
from
1ac24e7 to
033c906
Compare
cristhianescobar
force-pushed
the
cristhian/replace-sqldelight-with-room
branch
from
4bb1bbf to
2001de6
Compare
cristhianescobar
had a problem deploying
to
staging
GitHub Actions
Failure
cristhianescobar
force-pushed
the
cristhian/replace-sqldelight-with-room
branch
from
a0a22a0 to
233ec3e
Compare
|
This PR is waiting on the next version of Room, the issue right now is that it cannot properly link the db implementation on iOS and therefore I am not able to build. But there is a bug reported that should be addressed very soon https://issuetracker.google.com/issues/342905180?pli=1 |
cristhianescobar
force-pushed
the
cristhian/replace-sqldelight-with-room
branch
from
233ec3e to
ca3b3ab
Compare
cristhianescobar
force-pushed
the
cristhian/replace-sqldelight-with-room
branch
from
665f393 to
6e4d84e
Compare
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to migrate to Room that is now supported on KMP and away from SQL Delight, given it's easier to mantain and update databases long term.
We have a feature flag that toggles between the current DB implementation and Room.
Before we merge this PR we need to be able to build on both clients:
Here is the documentation for Room if you are curious