fix(dynamodb): remove deprecated function

[eusebiu-constantin-petu-dbk]

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[andaaron]

Looks good, does it fix a specific issue?

[eusebiu-constantin-petu-dbk]

Looks good, does it fix a specific issue?

The fact that here: #2853 users are getting 404 made me think that maybe this deprecated custom resolver func causes it? I'm not sure though, just a shot in the dark.

STS: AssumeRoleWithWebIdentity, https response error StatusCode: 404

[eusebiu-constantin-petu-dbk]

Hello @huynguyen-anduin, can you try this patch?

[codecov]

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (d6b38c0) to head (1fc8532).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/storage/cache/dynamodb.go	70.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2888      +/-   ##
==========================================
- Coverage   91.89%   91.88%   -0.02%     
==========================================
  Files         170      170              
  Lines       30291    30290       -1     
==========================================
- Hits        27836    27832       -4     
- Misses       1827     1828       +1     
- Partials      628      630       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rchincha]

Hello @huynguyen-anduin, can you try this patch?

Also @xakraz?

[xakraz]

I will try it this week

[xakraz]

@eusebiu-constantin-petu-dbk I have built a container from your branch and deployed it for testing.
I got another error now:

{"level":"error","field":"apikeytablename","goroutine":1,"caller":"zotregistry.dev/zot/pkg/meta/meta.go:129","time":"2025-01-29T14:14:50.90971916Z","message":"failed to parse CacheDriver config, field is not present"}
{"level":"panic","goroutine":1,"caller":"zotregistry.dev/zot/pkg/meta/meta.go:110","time":"2025-01-29T14:14:50.909775609Z","message":"dynamo parameters are not specified correctly, can't proceed"}
panic: dynamo parameters are not specified correctly, can't proceed

Here is the corresponding config

  {
      "storage": {
        "rootDirectory": "/var/lib/registry",
        "storageDriver": {
          "name": "s3",
          "rootdirectory": "/zot",
          "region": "eu-west-3",
          "bucket": "test-zot-k7zw422",
          "forcepathstyle": true,
          "secure": true,
          "skipverify": false
        },
        "dedupe": true,
        "remoteCache": true,
        "cacheDriver": {
          "name": "dynamodb",
          "endpoint": "https://dynamodb.eu-west-3.amazonaws.com",
          "region": "eu-west-3",
          "cacheTablename": "ZotBlobTable",
          "imageMetaTablename": "ZotImageMetaTable",
          "manifestDataTablename": "ZotManifestDataTable",
          "repoBlobsInfoTablename": "ZotRepoBlobsInfoTable",
          "repoMetaTablename": "ZotRepoMetadataTable",
          "userDataTablename": "ZotUserDataTable",
          "versionTablename": "ZotVersion"
        }
      },
...
}

IAM Permissions (Terraform code 😅 )

{
    Version = "2012-10-17",
    Statement = [
      {
        Effect = "Allow",
        Action = [
          "s3:ListBucket",
          "s3:ListBucketMultipartUploads",
          "s3:GetBucketLocation"
        ]
        Resource = [
          "arn:aws:s3:::test-zot-k7zw422"
        ]
      },
      {
        Effect = "Allow",
        Action = [
          "s3:GetObject",
          "s3:PutObject",
          "s3:DeleteObject",
          "s3:ListMultipartUploadParts",
          "s3:AbortMultipartUpload"
        ]
        Resource = [
          "arn:aws:s3:::test-zot-k7zw422/*"
        ]
      },
      {
        Effect = "Allow",
        Action = [
          "dynamodb:CreateTable",
          "dynamodb:GetItem",
          "dynamodb:UpdateItem",
          "dynamodb:DeleteItem"
        ],
        Resource = [
          format("arn:aws:dynamodb:*:%s:table/*",
            data.aws_caller_identity.current.id
          )
        ]
      }
    ]
  }

[eusebiu-constantin-petu-dbk]

This error is in our code: try to also define a table for api keys.

"apikeyTablename":"ZotApiKeyTable" in dynamodb config and try again, thank you!

[andaaron]

This error is in our code: try to also define a table for api keys.

"apikeyTablename":"ZotApiKeyTable" in dynamodb config and try again, thank you!

We should be more explicit in that error message