fix(headers): set Cross-Origin-Resource-Policy header for UI requests #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 170 170
Lines 30282 30285 +3
=======================================
+ Hits 27824 27827 +3
Misses 1829 1829
Partials 629 629 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrei Aaron <[email protected]>
andaaron
force-pushed
the
corp
branch
2 times, most recently
from
ace9d6f to
7320ff0
Compare
…buntu 24 Workaround this: The Ubuntu 22 github free runner is not powerful enough to run all these tests. We need a real fix on stacker side Signed-off-by: Andrei Aaron <[email protected]>
|
@rchincha, I tried downgrading Ubuntu, or upgrading stacker to v1.0.0, neither works. Commented out the test using stacker. See commit messages. |
Naikum
approved these changes
Jan 17, 2025
eusebiu-constantin-petu-dbk
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.