feat(ui): let UI delete manifests if current user has permissions to … #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
force-pushed
the
ui_delete_tag
branch
from
60306d4 to
622edc6
Compare
eusebiu-constantin-petu-dbk
requested review from
shimish2,
rchincha and
andaaron
as code owners
andaaron
reviewed
Dec 11, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
ui_delete_tag
branch
4 times, most recently
from
b4af79c to
8b17989
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2132 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 165 165
Lines 28681 28688 +7
=======================================
+ Hits 26410 26417 +7
Misses 1675 1675
Partials 596 596 ☔ View full report in Codecov by Sentry. |
andaaron
reviewed
Dec 12, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
ui_delete_tag
branch
4 times, most recently
from
b36115b to
0578ff3
Compare
| @@ -246,10 +246,14 @@ func RepoIsUserAvailable(ctx context.Context, repoName string) (bool, error) { | |||
| return false, err | |||
| } | |||
|
|
|||
| // no authn/authz enabled on server | |||
| if uac == nil { | |||
There was a problem hiding this comment.
is not reachable anymore, uac can not be nil
andaaron
approved these changes
Dec 13, 2023
…do so - added a new field 'IsDeletable' for graphql ImageSummary struct. - apply cors on DeleteManifest route Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
ui_delete_tag
branch
from
0578ff3 to
e386aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…do so
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.