build(go): switch to go 1.21 #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
- Coverage 92.92% 92.89% -0.03%
==========================================
Files 165 165
Lines 21582 21582
==========================================
- Hits 20054 20048 -6
- Misses 952 956 +4
- Partials 576 578 +2 ☔ View full report in Codecov by Sentry. |
andaaron
force-pushed
the
go1.21-2
branch
2 times, most recently
from
18bc348 to
65ce943
Compare
andaaron
requested review from
rchincha and
eusebiu-constantin-petu-dbk
as code owners
andaaron
force-pushed
the
go1.21-2
branch
5 times, most recently
from
ea08507 to
5420ce9
Compare
andaaron
commented
Jan 31, 2024
andaaron
force-pushed
the
go1.21-2
branch
3 times, most recently
from
2cf93d2 to
b1a0cd3
Compare
|
The ci failure is expected since we are not making it aware that go version has changed across this PR. |
|
@andaaron pls sign the commit and re-push. |
Also update to the latest swaggo version, as the previous one did not work with go 1.21 Signed-off-by: Andrei Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update to the latest swaggo version, as the previous one did not work with go 1.21
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.