Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(zui): add new makefile variables for the zui repo #2030

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

andaaron
Copy link
Contributor

To enable building zui from forks in case of local testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

To enable building zui from forks in case of local testing

Signed-off-by: Andrei Aaron <[email protected]>
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2030 (194d50a) into main (4ed4661) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2030   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         164      164           
  Lines       27657    27657           
=======================================
  Hits        25438    25438           
  Misses       1644     1644           
  Partials      575      575           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@andaaron andaaron marked this pull request as ready for review November 13, 2023 14:13
@andaaron andaaron changed the title build(zui): add new makefile variable for the zui repo build(zui): add new makefile variables for the zui repo Nov 13, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andaaron andaaron self-assigned this Nov 13, 2023
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is useful if we want to switch repos to test changes.

@rchincha rchincha merged commit 3492f0a into project-zot:main Nov 13, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants