fix(coverage): add coverage for boltdb and dynamo #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentiuNiculae
force-pushed
the
proto-coverage
branch
3 times, most recently
from
a13dfd0 to
d198918
Compare
Codecov Report
@@ Coverage Diff @@
## main #2018 +/- ##
==========================================
+ Coverage 90.13% 91.93% +1.80%
==========================================
Files 164 164
Lines 27651 27645 -6
==========================================
+ Hits 24923 25416 +493
+ Misses 2012 1652 -360
+ Partials 716 577 -139
... and 4 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
laurentiuNiculae
force-pushed
the
proto-coverage
branch
6 times, most recently
from
a75fc4b to
7e7504c
Compare
laurentiuNiculae
force-pushed
the
proto-coverage
branch
3 times, most recently
from
94dd882 to
10b1cda
Compare
laurentiuNiculae
requested review from
shimish2,
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
laurentiuNiculae
force-pushed
the
proto-coverage
branch
from
10b1cda to
444b552
Compare
rchincha
reviewed
Nov 8, 2023
errors/errors.go
Outdated
| ErrLimitIsNegative = errors.New("pageturner: limit has negative value") | ||
| ErrOffsetIsNegative = errors.New("pageturner: offset has negative value") | ||
| ErrSortCriteriaNotSupported = errors.New("pageturner: the sort criteria is not supported") | ||
| ErrLimitIsNegative = errors.New("pagefinder: limit has negative value") |
laurentiuNiculae
changed the title
Signed-off-by: Laurentiu Niculae <[email protected]>
laurentiuNiculae
force-pushed
the
proto-coverage
branch
from
444b552 to
1a12bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.