fix(routes): fix cors headers for api keys and logout route #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
force-pushed
the
fix_apikey_cors
branch
from
d229166 to
85acfa0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1984 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.02%
==========================================
Files 164 164
Lines 27649 27651 +2
==========================================
+ Hits 24921 24929 +8
+ Misses 2012 2008 -4
+ Partials 716 714 -2
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
raulkele
previously approved these changes
Oct 31, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
fix_apikey_cors
branch
from
85acfa0 to
82734c8
Compare
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
eusebiu-constantin-petu-dbk
force-pushed
the
fix_apikey_cors
branch
from
82734c8 to
d148891
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
fix_apikey_cors
branch
from
d148891 to
fc2465f
Compare
Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
fix_apikey_cors
branch
from
fc2465f to
d1ab72c
Compare
adodon2go
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.