Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci 'TLS check' job is broken #1970

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

adodon2go
Copy link
Collaborator

What type of PR is this?
bug

Which issue does this PR fix:
#1968

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1970 (cffed29) into main (d2fbd27) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
- Coverage   91.97%   91.92%   -0.05%     
==========================================
  Files         155      155              
  Lines       26807    26807              
==========================================
- Hits        24655    24642      -13     
- Misses       1593     1604      +11     
- Partials      559      561       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adodon2go adodon2go force-pushed the ci-tls-check branch 4 times, most recently from 13855a9 to 0cacf6e Compare October 27, 2023 15:14
@adodon2go adodon2go self-assigned this Oct 27, 2023
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit f3bb68a into project-zot:main Oct 27, 2023
32 of 33 checks passed
@adodon2go adodon2go deleted the ci-tls-check branch October 29, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants