-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(log): replace panics with log fatal or log panic functions #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
==========================================
+ Coverage 91.87% 92.01% +0.14%
==========================================
Files 165 165
Lines 28125 28206 +81
==========================================
+ Hits 25840 25955 +115
+ Misses 1687 1661 -26
+ Partials 598 590 -8 ☔ View full report in Codecov by Sentry. |
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
2 times, most recently
from
August 25, 2023 08:02
fa4643d
to
e6cc319
Compare
laurentiuNiculae
requested review from
adodon2go,
eusebiu-constantin-petu-dbk,
rchincha and
andaaron
as code owners
August 25, 2023 08:40
andaaron
reviewed
Aug 28, 2023
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
5 times, most recently
from
August 28, 2023 13:45
064d471
to
e85cb5b
Compare
andaaron
reviewed
Aug 28, 2023
andaaron
reviewed
Aug 28, 2023
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
9 times, most recently
from
September 4, 2023 15:31
f65de52
to
17aa72c
Compare
andaaron
reviewed
Sep 5, 2023
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
4 times, most recently
from
September 13, 2023 09:05
4738576
to
c96b3bc
Compare
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
9 times, most recently
from
November 9, 2023 12:11
95ea598
to
8d18a2e
Compare
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
from
November 9, 2023 16:43
8d18a2e
to
c742b1c
Compare
andaaron
reviewed
Nov 10, 2023
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
4 times, most recently
from
November 13, 2023 10:27
9ecba16
to
66faa58
Compare
andaaron
previously approved these changes
Nov 13, 2023
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
5 times, most recently
from
November 16, 2023 12:40
37648ed
to
d4defed
Compare
andaaron
approved these changes
Nov 16, 2023
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
3 times, most recently
from
November 22, 2023 12:45
fbd523f
to
d8c7812
Compare
Signed-off-by: Laurentiu Niculae <[email protected]>
laurentiuNiculae
force-pushed
the
log-remove-panic
branch
from
November 22, 2023 17:26
d8c7812
to
2869ccc
Compare
andaaron
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
Closes #1686
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.