fix(proto): the size of the repo should be int64, since that is the s…

…ame type used for the manifest/config/index/digest sizes it sums up. Using int32 may result in negative size values when returned by the graphql API Signed-off-by: Andrei Aaron <[email protected]>
project-zot · Dec 8, 2023 · 8e397dd · 8e397dd
1 parent 79e1402
commit 8e397dd
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/pkg/meta/common/common.go b/pkg/meta/common/common.go
@@ -262,7 +262,7 @@ func AddImageMetaToRepoMeta(repoMeta *proto_go.RepoMeta, repoBlobs *proto_go.Rep
 	size, platforms, vendors := recalculateAggregateFields(repoMeta, repoBlobs)
 	repoMeta.Vendors = vendors
 	repoMeta.Platforms = platforms
-	repoMeta.Size = int32(size)
+	repoMeta.Size = size
 
 	imageBlobInfo := repoBlobs.Blobs[imageMeta.Digest.String()]
 	repoMeta.LastUpdatedImage = mConvert.GetProtoEarlierUpdatedImage(repoMeta.LastUpdatedImage,
@@ -316,7 +316,7 @@ func RemoveImageFromRepoMeta(repoMeta *proto_go.RepoMeta, repoBlobs *proto_go.Re
 		}
 	}
 
-	repoMeta.Size = int32(updatedSize)
+	repoMeta.Size = updatedSize
 	repoMeta.Vendors = updatedVendors
 	repoMeta.Platforms = updatedPlatforms
 	repoMeta.LastUpdatedImage = updatedLastImage

diff --git a/pkg/meta/convert/convert.go b/pkg/meta/convert/convert.go
@@ -445,7 +445,7 @@ func GetRepoMeta(protoRepoMeta *proto_go.RepoMeta) mTypes.RepoMeta {
 		Name:             protoRepoMeta.Name,
 		Tags:             GetTags(protoRepoMeta.Tags),
 		Rank:             int(protoRepoMeta.Rank),
-		Size:             int64(protoRepoMeta.Size),
+		Size:             protoRepoMeta.Size,
 		Platforms:        GetPlatforms(protoRepoMeta.Platforms),
 		Vendors:          protoRepoMeta.Vendors,
 		IsStarred:        protoRepoMeta.IsStarred,

diff --git a/pkg/meta/convert/convert_proto.go b/pkg/meta/convert/convert_proto.go
@@ -19,7 +19,7 @@ func GetProtoRepoMeta(repo mTypes.RepoMeta) *proto_go.RepoMeta {
 		Statistics:       GetProtoStatistics(repo.Statistics),
 		Signatures:       GetProtoSignatures(repo.Signatures),
 		Referrers:        GetProtoReferrers(repo.Referrers),
-		Size:             int32(repo.Size),
+		Size:             repo.Size,
 		Vendors:          repo.Vendors,
 		Platforms:        GetProtoPlatforms(repo.Platforms),
 		LastUpdatedImage: GetProtoLastUpdatedImage(repo.LastUpdatedImage),

diff --git a/pkg/meta/proto/gen/meta.pb.go b/pkg/meta/proto/gen/meta.pb.go
diff --git a/pkg/meta/proto/meta/meta.proto b/pkg/meta/proto/meta/meta.proto
@@ -52,7 +52,7 @@ message RepoMeta {
 
     int32 Stars = 9;
 
-    int32 Size = 10;
+    int64 Size = 10;
     repeated string   Vendors   = 11;
     repeated oci_v1.Platform Platforms = 12;
     optional RepoLastUpdatedImage LastUpdatedImage = 13;